Support for Mastercard new 2-series BIN range

jim9675309 · November 22, 2019, 12:38pm

This is a terrible way to represent the code changes. I don’t have the environment set up to build and test. This is just hand-edited to represent the potential changes.

core/src/main/java/lucee/runtime/op/validators/ValidateCreditCard.java
119: new LCR(222100000000000L, 272099999999999L, 16, MASTERCARD, true),
242: // MASTERCARD 2221-2720 51-55 16 mod 10

test/functions/IsValid.cfc
197: assertTrue(IsValid(“creditcard”,‘2223000048400011’));

Zackster · November 22, 2019, 1:54pm

Can you file a bug in jira and file a PR in github against the 5.3 branch?

you can do it all the code changes via the github web ui, if you don’t want to check out and create a fork locally

github.com

lucee/Lucee/blob/5.3/core/src/main/java/lucee/runtime/op/validators/ValidateCreditCard.java#L119


      
          	/**
          	 * build table of which ranges of credit card number belong to which vendor
          	 */
          	private static void buildRanges() {
          		// careful, no lead zeros allowed
          		// low high len vendor mod-10?
          		ranges = new LCR[] { new LCR(4000000000000L, 4999999999999L, 13, VISA, true), new LCR(30000000000000L, 30599999999999L, 14, DINERS, true),
          				new LCR(36000000000000L, 36999999999999L, 14, DINERS, true), new LCR(38000000000000L, 38999999999999L, 14, DINERS, true),
          				new LCR(180000000000000L, 180099999999999L, 15, JCB, true), new LCR(201400000000000L, 201499999999999L, 15, ENROUTE, false),
          				new LCR(213100000000000L, 213199999999999L, 15, JCB, true), new LCR(214900000000000L, 214999999999999L, 15, ENROUTE, false),
          				new LCR(340000000000000L, 349999999999999L, 15, AMEX, true), new LCR(370000000000000L, 379999999999999L, 15, AMEX, true),
          				new LCR(3000000000000000L, 3999999999999999L, 16, JCB, true), new LCR(4000000000000000L, 4999999999999999L, 16, VISA, true),
          				new LCR(5100000000000000L, 5599999999999999L, 16, MASTERCARD, true), new LCR(6011000000000000L, 6011999999999999L, 16, DISCOVER, true) }; // end table
          		// initialisation
          	}
          
          
	/**
          	 * Finds a matching range in the ranges array for a given creditCardNumber.
          	 *
          	 * @param creditCardNumber number on card.
          	 *

jim9675309 · November 22, 2019, 6:03pm

I haven’t built or tested the change. Doesn’t sound like it’s ready for a pull request.

Zackster · November 24, 2019, 7:00am

ok, so you know what you need to do then to get this addressed