onRequestStart return false?

dev support
1

Hi Everyone,
We have two instances, separated geographically.
The code on one instance is NOT identical to the other.
They have morphed into bespoke versions of the same application.

We have an issue on one of our servers, that is not on the other and so while doing a diff between the two I found something that I thought was peculiar…

On one of our servers, the onRequestStart method ends with return false (the other is true - which is what I expect).

It is unlikely - this difference is the cause of our issue… But nonetheless - it leaves me with a question that I’d like an answer for please…

Is there any good reason to return false from the onRequestStart() method?

(I know what returning false does…
We do have the following block in our own onRequestStart() method:

if(structKeyExists(application, "reloadExpiry")) {
    writeOutput("Please wait while we finish loading the application...");

    if(application.reloadExpiry <= Now()) {
        applicationStop();
    }

    return false;
}

Irrespective of whether or not that code is appropriate - I understand the reasoning by returning false from this block.)

Our application uses the Mach-II framework - and for the framework to work, you call Mach-IIs method handleRequest()

And it is the line following handleRequest() that the return false, appears.
Perhaps it’s a non-event in this case?
Since the handleRequest() method is run, prior?
So in effect it is somewhat like a no-op, perhaps?

All I know is : It seems odd - and I thought I would ask if returning false in this situation, made sense to anyone?

As always - thanks!

2

As far as I know, if onRequestStart returns true, Lucee/ColdFusion will process the requested page. If, on the other hand, onRequestStart returns false, Lucee/ColdFusion will not process the requested page.

I therefore agree with you that handleRequest(); followed by return false; is odd. In fact, I consider it to be a contradiction in terms:

boolean function onRequestStart(string targetPage) {
	// Presumably instructs application server to handle request
	handleRequest();
	
	// Instructs application server to discontinue request: a contradiction in terms
	return false;
}

If you insist that onRequestStart return a boolean, then I will expect something like

boolean function onRequestStart(string targetPage) {
	if (someRequestConditionIsSatisfied) {
		handleRequest();
		
		return true;
	} else {
		return false;
	}
}