CF / Lucee incompatibility for cfcookie

Gunter · November 13, 2019, 9:40am

I’m migrating an application from CF 9.01 to Lucee 5.3.3.62, and having trouble with Cookies.
In CF, there are cookies defined to expire after 10 hrs, this is done like this:
<cfcookie name="testCookie1" value="ENG" expires=0.417>

The 0.417 represents the 10hrs (10/24).
This works fine in CF 9.01. However in Lucee, it looks like only integer numbers are allowed, and in my example, the Cookie expires immediately (I suspect the 0.417 becomes 0).

Is this expected behaviour? I was looking for a workaround, like specifying the complete expire date/time, but I wonder that will work. cf. documentation:

ColdFusion: A date or date/time object (for example, 10/09/97).

Lucee: Can be specified as a date (as in, 10/09/97)

Does this means, no time part? So, cookies can only expire after an integer number of days?

Zackster · November 13, 2019, 10:39am

github.com

lucee/Lucee/blob/5.3/core/src/main/java/lucee/runtime/type/scope/CookieImpl.java#L263


      
          		_addCookie(key, Caster.toString(value, ""), expires, secure, path, domain, httpOnly, preserveCase, encode, CookieData.SAMESITE_EMPTY);
          		super.setEL(key, value);
          	}
          
          
	// FUTURE add to interface
          	public void setCookieEL(Collection.Key key, Object value, int expires, boolean secure, String path, String domain, boolean httpOnly, boolean preserveCase, boolean encode,
          			short samesite) {
          		_addCookie(key, Caster.toString(value, ""), expires, secure, path, domain, httpOnly, preserveCase, encode, samesite);
          		super.setEL(key, value);
          	}
          
          
	private void _addCookie(Key key, String value, int expires, boolean secure, String path, String domain, boolean httpOnly, boolean preserveCase, Boolean encode,
          			short samesite) {
          		String name = preserveCase ? key.getString() : key.getUpperString();
          
          
		// build the value
          		StringBuilder sb = new StringBuilder();
          		/* Name */ sb.append(enc(name)).append('=').append(encode == null ? enc(value) : enc(value, encode.booleanValue()));
          		/* Path */sb.append(";Path=").append(enc(path));
          		/* Domain */if (!StringUtil.isEmpty(domain)) sb.append(";Domain=").append(enc(domain));
          		/* Expires */if (expires != EXPIRES_NULL) sb.append(";Expires=").append(DateTimeUtil.toHTTPTimeString(System.currentTimeMillis() + (expires * 1000L), false));

Can you file a bug please? add the label acf-compat

Gunter · November 13, 2019, 10:44am

Thanks, I will.
Edit: done: [LDEV-2568] - Lucee