Update Page Error key [OTHERVERSIONS] doesn't exist

Zackster · May 31, 2019, 12:41pm

line 92, a check is made to see if updateData.otherVersions exists

lucee/Lucee/blob/5.3/core/src/main/cfml/context/admin/services.update.cfm#L92


      
          		updateData=getAvailableVersion();*/
          
          
		if(updateData.provider.location EQ "https://update.lucee.org" || updateData.provider.location EQ "http://update.lucee.org"){
          			version = "lucee";
          		} 
          		else{
          			version = "custom";
          		}
          		versionsStr = {};
          		versionsStr.snapShot = {};
          		versionsStr.pre_Release= {};
          		versionsStr.release = {};
          		if(version eq 'custom'){
          			versionsStr.custom = {};
          		}
          		for(type in versionsStr){
          			versionsStr[type].upgrade = [];
          			versionsStr[type].downgrade = [];
          		}
          		if(version eq 'custom' && structKeyExists(updateData, "otherVersions") && Len(updateData.otherVersions)){
          			for(versions in updateData.otherVersions){

then on line 109 it just assumes it’s defined

github.com

lucee/Lucee/blob/5.3/core/src/main/cfml/context/admin/services.update.cfm#L109


      
          			versionsStr[type].downgrade = [];
          		}
          		if(version eq 'custom' && structKeyExists(updateData, "otherVersions") && Len(updateData.otherVersions)){
          			for(versions in updateData.otherVersions){
          				if(toVersionSortable(versions) LTE toVersionSortable(server.lucee.version)){
          					arrayPrepend(versionsStr.custom.downgrade, versions);
          				}
          				else{
          					arrayPrepend(versionsStr.custom.upgrade, versions);
          				}
          				hasOptions=true;
          			}
          		}
          		
          		admin
          			action="getMinVersion"
          			type="#request.adminType#"
          			password="#session["password"&request.adminType]#"
          			returnvariable="minVersion";
          		minVs = toVersionSortable(minVersion);

Did this occur around the time of the server outage?

perhaps the update logic needs to be more robust when the lucee webservices are down?

this is reproduceable on localhost if you turn off wifi, restart lucee and go to server admin update
https://luceeserver.atlassian.net/browse/LDEV-2301