Lucee html 5 multiple upload patch

Micha,

on the old ticket and pull request for this, you said I broke compatibility
with other things with my change, but I didn’t know what those things were.
https://issues.jboss.org/browse/RAILO-2468

I have never experienced a problem from that change, but I’m sure you are
right.

I just upgraded from Railo to Lucee for the first time, and learned how to
install / build it from the bitbucket instructions (you made it easier now

  • good work), and I did this patch again, and again it fixes the multiple
    upload feature.

On the master branch of lucee on bitbucket, I found another way to ensure
the key on that fileItems object is a unique name.

Is this an acceptable fix now?

\lucee-git\lucee-java\lucee-core\src\lucee\runtime\type\scope\FormImpl.java
line 1: 184: change:
fileItems.put(item.getFieldName().toLowerCase(),
to:
fileItems.put(getFileName(),

Micha, I would like this fixed as well, as I think I commented on that
ticket many times. Also I think there might be an inherent slowness with
file upload in Lucee, compared to ACF, I have a setup now where I can test
this, so I will let you know, but maybe the whole thing needs looking into
more closely or even rewriting completely.

Also Bruce, if you want to submit a pull request the code base is now on
GitHub (https://github.com/lucee/Lucee4) and for Lucee 5 (
https://github.com/lucee/Lucee) it changes quiet a bit.

Kind regards,

Andrew
about.me http://about.me/andrew_dixon - mso http://www.mso.net - Lucee
Association Member http://lucee.orgOn 8 August 2015 at 19:17, Bruce Kirkpatrick <@Bruce_Kirkpatrick> wrote:

Micha,

on the old ticket and pull request for this, you said I broke
compatibility with other things with my change, but I didn’t know what
those things were.
https://issues.jboss.org/browse/RAILO-2468

I have never experienced a problem from that change, but I’m sure you are
right.

I just upgraded from Railo to Lucee for the first time, and learned how to
install / build it from the bitbucket instructions (you made it easier now

  • good work), and I did this patch again, and again it fixes the multiple
    upload feature.

On the master branch of lucee on bitbucket, I found another way to ensure
the key on that fileItems object is a unique name.

Is this an acceptable fix now?

\lucee-git\lucee-java\lucee-core\src\lucee\runtime\type\scope\FormImpl.java
line 1: 184: change:
fileItems.put(item.getFieldName().toLowerCase(),
to:
fileItems.put(getFileName(),


See Lucee at CFCamp Oct 22 & 23 2015 @ Munich Airport, Germany - Get your
ticket NOW - http://www.cfcamp.org/

You received this message because you are subscribed to the Google Groups
“Lucee” group.
To unsubscribe from this group and stop receiving emails from it, send an
email to lucee+unsubscribe@googlegroups.com.
To post to this group, send email to lucee@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/lucee/61dd3532-80c0-450f-ad2f-44bca7d3925d%40googlegroups.com
https://groups.google.com/d/msgid/lucee/61dd3532-80c0-450f-ad2f-44bca7d3925d%40googlegroups.com?utm_medium=email&utm_source=footer
.
For more options, visit https://groups.google.com/d/optout.

Yippee… :slight_smile:

Kind regards,

Andrew
about.me http://about.me/andrew_dixon - mso http://www.mso.net - Lucee
Association Member http://lucee.orgOn 22 March 2016 at 15:36, Bruce Kirkpatrick <@Bruce_Kirkpatrick> wrote:

Michael posted a commit for multiple file upload support in the newest
version of 4.5 and 5 on github today.

On Saturday, August 8, 2015 at 3:00:24 PM UTC-4, Andrew Dixon wrote:

Micha, I would like this fixed as well, as I think I commented on that
ticket many times. Also I think there might be an inherent slowness with
file upload in Lucee, compared to ACF, I have a setup now where I can test
this, so I will let you know, but maybe the whole thing needs looking into
more closely or even rewriting completely.

Also Bruce, if you want to submit a pull request the code base is now on
GitHub (https://github.com/lucee/Lucee4) and for Lucee 5 (
https://github.com/lucee/Lucee) it changes quiet a bit.

Kind regards,

Andrew
about.me http://about.me/andrew_dixon - mso http://www.mso.net - Lucee
Association Member http://lucee.org

On 8 August 2015 at 19:17, Bruce Kirkpatrick br...@farbeyondcode.com wrote:

Micha,

on the old ticket and pull request for this, you said I broke
compatibility with other things with my change, but I didn’t know what
those things were.
https://issues.jboss.org/browse/RAILO-2468

I have never experienced a problem from that change, but I’m sure you
are right.

I just upgraded from Railo to Lucee for the first time, and learned how
to install / build it from the bitbucket instructions (you made it easier
now - good work), and I did this patch again, and again it fixes the
multiple upload feature.

On the master branch of lucee on bitbucket, I found another way to
ensure the key on that fileItems object is a unique name.

Is this an acceptable fix now?

\lucee-git\lucee-java\lucee-core\src\lucee\runtime\type\scope\FormImpl.java
line 1: 184: change:
fileItems.put(item.getFieldName().toLowerCase(),
to:
fileItems.put(getFileName(),


See Lucee at CFCamp Oct 22 & 23 2015 @ Munich Airport, Germany - Get
your ticket NOW - http://www.cfcamp.org/

You received this message because you are subscribed to the Google
Groups “Lucee” group.
To unsubscribe from this group and stop receiving emails from it, send
an email to lucee+un...@googlegroups.com.
To post to this group, send email to lu...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/lucee/61dd3532-80c0-450f-ad2f-44bca7d3925d%40googlegroups.com
https://groups.google.com/d/msgid/lucee/61dd3532-80c0-450f-ad2f-44bca7d3925d%40googlegroups.com?utm_medium=email&utm_source=footer
.
For more options, visit https://groups.google.com/d/optout.


Love Lucee? Become a supporter and be part of the Lucee project today! -
http://lucee.org/supporters/become-a-supporter.html


You received this message because you are subscribed to the Google Groups
“Lucee” group.
To unsubscribe from this group and stop receiving emails from it, send an
email to lucee+unsubscribe@googlegroups.com.
To post to this group, send email to lucee@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/lucee/faa3c65b-06a6-4fa3-b97f-56fa15a19fe4%40googlegroups.com
https://groups.google.com/d/msgid/lucee/faa3c65b-06a6-4fa3-b97f-56fa15a19fe4%40googlegroups.com?utm_medium=email&utm_source=footer
.

For more options, visit https://groups.google.com/d/optout.

Michael posted a commit for multiple file upload support in the newest
version of 4.5 and 5 on github today.On Saturday, August 8, 2015 at 3:00:24 PM UTC-4, Andrew Dixon wrote:

Micha, I would like this fixed as well, as I think I commented on that
ticket many times. Also I think there might be an inherent slowness with
file upload in Lucee, compared to ACF, I have a setup now where I can test
this, so I will let you know, but maybe the whole thing needs looking into
more closely or even rewriting completely.

Also Bruce, if you want to submit a pull request the code base is now on
GitHub (https://github.com/lucee/Lucee4) and for Lucee 5 (
https://github.com/lucee/Lucee) it changes quiet a bit.

Kind regards,

Andrew
about.me http://about.me/andrew_dixon - mso http://www.mso.net - Lucee
Association Member http://lucee.org

On 8 August 2015 at 19:17, Bruce Kirkpatrick <br...@farbeyondcode.com <javascript:>> wrote:

Micha,

on the old ticket and pull request for this, you said I broke
compatibility with other things with my change, but I didn’t know what
those things were.
https://issues.jboss.org/browse/RAILO-2468

I have never experienced a problem from that change, but I’m sure you are
right.

I just upgraded from Railo to Lucee for the first time, and learned how
to install / build it from the bitbucket instructions (you made it easier
now - good work), and I did this patch again, and again it fixes the
multiple upload feature.

On the master branch of lucee on bitbucket, I found another way to ensure
the key on that fileItems object is a unique name.

Is this an acceptable fix now?

\lucee-git\lucee-java\lucee-core\src\lucee\runtime\type\scope\FormImpl.java
line 1: 184: change:
fileItems.put(item.getFieldName().toLowerCase(),
to:
fileItems.put(getFileName(),


See Lucee at CFCamp Oct 22 & 23 2015 @ Munich Airport, Germany - Get your
ticket NOW - http://www.cfcamp.org/

You received this message because you are subscribed to the Google Groups
“Lucee” group.
To unsubscribe from this group and stop receiving emails from it, send an
email to lucee+un...@googlegroups.com <javascript:>.
To post to this group, send email to lu...@googlegroups.com <javascript:>
.
To view this discussion on the web visit
https://groups.google.com/d/msgid/lucee/61dd3532-80c0-450f-ad2f-44bca7d3925d%40googlegroups.com
https://groups.google.com/d/msgid/lucee/61dd3532-80c0-450f-ad2f-44bca7d3925d%40googlegroups.com?utm_medium=email&utm_source=footer
.
For more options, visit https://groups.google.com/d/optout.